Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .errors to the @babel/parser return type definitions #13653

Merged
merged 1 commit into from
Aug 7, 2021

Conversation

sosukesuzuki
Copy link
Member

@sosukesuzuki sosukesuzuki commented Aug 7, 2021

Q                       A
Fixed Issues? N/A
Patch: Bug Fix? Y
Tests Added + Pass? Yes
License MIT

This PR fixes it on the babel-parser side, or should fix it on the babel-types side?

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/48003/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 7, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cbe7ced:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@fedeci fedeci added pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Aug 7, 2021
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR fixes it on the babel-parser side, or should fix it on the babel-types side?

It's correct like this: they technically aren't part of the AST, but @babel/parser attatches them as an extra property.

@nicolo-ribaudo nicolo-ribaudo changed the title fix(babel/parser): add type definitions of recoverable errors Add .errors to the @babel/parser return type definitions Aug 7, 2021
@nicolo-ribaudo nicolo-ribaudo merged commit e294beb into babel:main Aug 7, 2021
@sosukesuzuki sosukesuzuki deleted the support-errors branch August 7, 2021 17:38
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 7, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants