Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: assure left bracket is not consumed after dot #13695

Merged
merged 2 commits into from Aug 20, 2021

Conversation

@JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Aug 19, 2021

Q                       A
Fixed Issues? Fixes #13694
Patch: Bug Fix? Y
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This PR fixes a regression introduced in #11871. When parsing member expression, Babel should not consume left bracket [ after dot ..

@babel-bot
Copy link
Collaborator

@babel-bot babel-bot commented Aug 19, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/48277/

} else if (optional || this.match(tt.bracketL) || this.eat(tt.dot)) {
return this.parseMember(base, startPos, startLoc, state, optional);
} else if (
(computed = this.eat(tt.bracketL)) ||
Copy link
Member

@jridgewell jridgewell Aug 19, 2021

Nit: this is kinda ugly. Mind breaking this else if into a regular else and perform the mutation there?

@codesandbox
Copy link

@codesandbox codesandbox bot commented Aug 19, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit da5a288:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@fedeci fedeci merged commit 976bfbb into babel:main Aug 20, 2021
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants