Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ts] precise return type on createTypeAnnotationBasedOnTypeof (babel-types) #13844

Conversation

@lightmare
Copy link
Contributor

@lightmare lightmare commented Oct 13, 2021

Q                       A
Fixed Issues? none
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? none added
Documentation PR Link
Any Dependency Changes?
License MIT

Diff best viewed ignoring whitespace changes, it'll show more clearly that only the function type is changed to be more granular — instead of a union argument type and a union return type, the argument now selects the return type. Remaining changes are just rewriting if-else chain to a switch.

@codesandbox
Copy link

@codesandbox codesandbox bot commented Oct 13, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8156bf5:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@babel-bot
Copy link
Collaborator

@babel-bot babel-bot commented Oct 13, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/49206/

Copy link
Contributor

@JLHwung JLHwung left a comment

Nice!

@nicolo-ribaudo nicolo-ribaudo merged commit 24aa1b4 into babel:main Oct 14, 2021
25 of 28 checks passed
@lightmare lightmare deleted the refactor-createTypeAnnotationBasedOnTypeof branch Oct 14, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants