Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force loading plugins/presets from the monorepo in tests #13858

Merged

Conversation

@nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Oct 17, 2021

Q                       A
Fixed Issues? Fixes the CI failure in #13856
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

When using @babel/-prefixed plugins/presets, they are always loaded from node_modules. With Yarn 2 and Yarn 3 we were lucky enough that the version resolved in node_modules was a symlink to the monorepo version, but due to some changes to the hoisting algorithm this isn't true anymore in Yarn 3.1 (so it uncovered the bug).

@codesandbox
Copy link

@codesandbox codesandbox bot commented Oct 17, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8d0a1be:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@babel-bot
Copy link
Collaborator

@babel-bot babel-bot commented Oct 17, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/49251/

@nicolo-ribaudo nicolo-ribaudo force-pushed the load-monorepo-packages-in-tests branch from ece9f58 to 8d0a1be Oct 17, 2021
fedeci
fedeci approved these changes Oct 18, 2021
@nicolo-ribaudo nicolo-ribaudo merged commit 780aa48 into babel:main Oct 18, 2021
26 of 28 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the load-monorepo-packages-in-tests branch Oct 18, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants