Use Node.js interop when importing lib in test
#13995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/49945/ |
nicolo-ribaudo
force-pushed
the
test-import-lib-interop
branch
from
a9555c1
to
2a4ab03
Compare
4 tasks
nicolo-ribaudo
force-pushed
the
test-import-lib-interop
branch
from
2a4ab03
to
7411f5a
Compare
JLHwung
approved these changes
Nov 25, 2021
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another piece extracted from #13966. We where using the compiled import interop when importing
libfiles from theŧestfolder, to simulate an ESM-ESM interaction. However, the tests can be migrated to native ESM sooner thanlib, so we cannot have this abstraction.This PR aligns the tests with the same behavior they would have if run as native ESM.