Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix derived classes in Chrome <= 36 #14072

Merged
merged 2 commits into from Dec 30, 2021

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Dec 21, 2021

Q                       A
Fixed Issues? Fixes #14056
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Unfortunately we don't have the infrastructure to run tests in real old browsers, so you can either trust me and @romainmenke that it works or you can download Chrome <= 36 and try it yourself! 😅

@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 i: regression Spec: Classes labels Dec 21, 2021
@babel-bot
Copy link
Collaborator

@babel-bot babel-bot commented Dec 21, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/50451/

@romainmenke
Copy link

@romainmenke romainmenke commented Dec 21, 2021

Fix works in chrome 14-36 (I can't test older versions)

https://mrhenry.github.io/web-tests/#293ee801-4d53-4261-add3-dca6b9f8015f

  • 0.1 values indicates it is passing but used to fail, takes a few runs for values to settle back on 1.0
  • values that are still 0.0 are just rounded values (0.04 => 0.0)

No test cases dropped in score.

Screenshot 2021-12-21 at 19 27 49

not going to do further runs at this time as it's a bit wasteful.


edit : just read #14056 (comment)

unsure if we need to wait with rolling this out until we receive more info on that?


Update :

I had to remove the patch from our test suite so posting latest results here :

Screenshot 2021-12-29 at 14 51 54

Copy link
Contributor

@JLHwung JLHwung left a comment

Nit: can you also add link to the upstream issue?

https://bugs.chromium.org/p/v8/issues/detail?id=3334

@nicolo-ribaudo nicolo-ribaudo merged commit 2810dc6 into babel:main Dec 30, 2021
26 of 27 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the classes-chrome-36 branch Dec 30, 2021
@github-actions github-actions bot added the outdated label Apr 5, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
i: regression outdated PR: Bug Fix 🐛 Spec: Classes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants