Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable immutable yarn install during e2e-jest test #14262

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Feb 10, 2022

Q                       A
Fixed Issues? Fix recent jest e2e test failure because jest migrates to Yarn 3 (nice!)
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

yarn install will infer --immutable when it is executed in a CI environment. However in the e2e test we are bumping @babel/* deps so the lock file will be inevitably modified during install.

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51232/

@JLHwung JLHwung marked this pull request as ready for review February 10, 2022 23:03
@JLHwung JLHwung changed the title disable immutable yarn install on e2e-jest test disable immutable yarn install during e2e-jest test Feb 10, 2022
@JLHwung JLHwung merged commit e06c099 into babel:main Feb 11, 2022
@JLHwung JLHwung deleted the fix-jest-e2e-test branch February 11, 2022 13:44
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 14, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Fixes failing main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants