Fix the duplicate export initialization (#14272) #14276
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
nicolo-ribaudo
added
PR: Bug Fix 🐛
There was a problem hiding this comment.
Thanks! Could you add a test like the one I suggested in #14272 (comment)? It can go in a new packages/babel-plugin-transform-modules-commonjs/test/fixtures/regression/many-exports-chunked/ folder. You only have to create the options.json and input.mjs files, then yarn jest modules will automatically generate the output.js file.
|
@nicolo-ribaudo No problem, I will add some tests. |
JLHwung
approved these changes
Feb 16, 2022
jridgewell
approved these changes
Feb 16, 2022
|
Ping @JasinYip, we just need a test for the fixed behavior and then this PR can be merged 🙂 |
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The array
uninitializedExportNameshaven't reset to[]so the array would contains the previous chunks. This will make lots of duplicate initialization statements while the amount of exports more than 100.For more detail: #14272