Allow variable and function with the same name in static blocks #14336
Conversation
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51447/ |
nicolo-ribaudo
changed the title
nicolo-ribaudo
added
pkg: parser
PR: Bug Fix 🐛
|
if some checks are failing, should i make a new pull request instead? unfortunately there are some failing. |
...ges/babel-parser/test/fixtures/experimental/class-static-block/invalid-arguments/output.json
Outdated
Show resolved
Hide resolved
packages/babel-runtime-corejs2/helpers/esm/possibleConstructorReturn.js
Outdated
Show resolved
Hide resolved
|
i am very happy to see all the tests passed, i hope it will be merged |
| @@ -1,4 +1,4 @@ | |||
| var _typeof = require("./typeof.js")["default"]; | |||
| var _typeof = require("@babel/runtime-corejs3/helpers/typeof")["default"]; | |||
There was a problem hiding this comment.
Can you run make bootstrap to undo these unrelated changes?
Also, I suggest not opening pull requests from you main branch but creating a separate branch, so that we can directly push small fixes such as this one.
There was a problem hiding this comment.
@nicolo-ribaudo thanks, I ran make bootstrap. OK, next time I will create PRs from a separate branch. Please inform me in case there are some issues.
There was a problem hiding this comment.
After running make bootstrap, you also need to commit the new changes and push it to GitHub!
There was a problem hiding this comment.
sorry for such a long message!!!
i reran make bootstrap and after staging when I commit changes, I get "No staged files match any of provided globs. On branch main. Your branch is up to date with 'origin/main'." message. but I anyway ran git push -u origin main and got Everything up-to-date branch 'main' set up to track 'origin/main'.
(sidenote: I also checked out packages/babel-runtime-corejs3/helpers/possibleConstructorReturn.js on my local and remote repo and saw that var _typeof = require("./typeof.js")["default"]; is changed for var _typeof = require("@babel/runtime-corejs3/helpers/typeof")["default"];)
There was a problem hiding this comment.
Could you try giving me write access to your fork? It's probably somewhere in the settings of https://github.com/Yokubjon-J/babel. I can try fixing this problem.
There was a problem hiding this comment.
Whops sorry, this got automatically closed when I tried to push my changed. Could you reopen it, but from this new branch? https://github.com/Yokubjon-J/babel/tree/fix-14336
Also, I restored your main branch to be in sync with the main of this repository: in general I suggest never toughing it (other than syncing it with this repo), to prevent conflicts when we add new commits in this repository. You can update your local clone with git checkout main, git fetch origin and then git reset --hard origin/main. If you want to check our locally the new branch I created, you can then use git checkout fix-14336.
github-actions
bot
added
the
outdated
…claration in class static block #14257
it won't throw an error when var declaration and function declaration has a same name inside a static block of a class. the test file is inside
packages/babel-parser/test/fixtures/es2015/class/static-block-var-and-func-same-name