Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove git.io shortlinks from repo #14493

Merged
merged 2 commits into from Apr 27, 2022
Merged

Remove git.io shortlinks from repo #14493

merged 2 commits into from Apr 27, 2022

Conversation

Andoryuuta
Copy link
Contributor

@Andoryuuta Andoryuuta commented Apr 26, 2022

Github has deprecated git.io and will be disabling all links on April 29th.
This PR replaces all git.io shortened links with the URL they redirect to.

Q                       A
Fixed Issues? Removed soon-to-be-invalid shortlinks
Patch: Bug Fix? No
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? No
Documentation PR Link N/A
Any Dependency Changes? No
License MIT

@babel-bot
Copy link
Collaborator

@babel-bot babel-bot commented Apr 26, 2022

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51758/

@babel-bot
Copy link
Collaborator

@babel-bot babel-bot commented Apr 26, 2022

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51747/

Copy link
Contributor

@JLHwung JLHwung left a comment

Can you replace master to main?

@Andoryuuta
Copy link
Contributor Author

@Andoryuuta Andoryuuta commented Apr 26, 2022

Sure, I'll update the PR later today. The current URL's are just what the existing git.io links resolved to.

},
},
classProperties: {
syntax: {
name: "@babel/plugin-syntax-class-properties",
url: "https://github.com/babel/babel/tree/master/packages/babel-plugin-syntax-class-properties",
url: "https://github.com/babel/babel/tree/main/packages/babel-plugin-syntax-class-properties",
Copy link

@SukkaW SukkaW Apr 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URL returns 404.

},
},
classPrivateProperties: {
syntax: {
name: "@babel/plugin-syntax-class-properties",
url: "https://github.com/babel/babel/tree/master/packages/babel-plugin-syntax-class-properties",
url: "https://github.com/babel/babel/tree/main/packages/babel-plugin-syntax-class-properties",
Copy link

@SukkaW SukkaW Apr 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URL returns 404.

},
},
classPrivateMethods: {
syntax: {
name: "@babel/plugin-syntax-class-properties",
url: "https://github.com/babel/babel/tree/master/packages/babel-plugin-syntax-class-properties",
url: "https://github.com/babel/babel/tree/main/packages/babel-plugin-syntax-class-properties",
Copy link

@SukkaW SukkaW Apr 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URL returns 404.

Copy link
Contributor

@JLHwung JLHwung left a comment

The URLs returning 404 are archived plugins, we can fix them in another PR.

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Thanks! I agree, lets get this merged since it's quite urgent. We can iterate and improve the links later.

@nicolo-ribaudo nicolo-ribaudo changed the title Remove git.io shortlinks from repo [skip ci] Remove git.io shortlinks from repo Apr 27, 2022
@nicolo-ribaudo nicolo-ribaudo merged commit f05b877 into babel:main Apr 27, 2022
35 of 36 checks passed
@nicolo-ribaudo nicolo-ribaudo added the PR: Internal 🏠 label Apr 27, 2022
@Andoryuuta Andoryuuta deleted the remove-git_io_shortlinks branch Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Internal 🏠
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants