Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow liberal named type-as imports #14522

Merged
merged 1 commit into from May 4, 2022
Merged

fix: allow liberal named type-as imports #14522

merged 1 commit into from May 4, 2022

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented May 3, 2022

Q                       A
Fixed Issues? Fixes #14521
Patch: Bug Fix? Y
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Per #13802 (comment)

When parsing import { type foo, foo should be parsed as a liberal identifier and then throw if we don't see an as following and it is a keyword.

@JLHwung JLHwung added PR: Bug Fix 🐛 pkg: parser area: typescript labels May 3, 2022
@babel-bot
Copy link
Collaborator

@babel-bot babel-bot commented May 3, 2022

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51833/

@chriskrycho
Copy link

@chriskrycho chriskrycho commented May 3, 2022

Can confirm this works for import { type default as whatever } from 'somewhere';. Thanks so much for the quick turnaround on this!

@JLHwung JLHwung merged commit e29e915 into babel:main May 4, 2022
35 checks passed
@JLHwung JLHwung deleted the fix-14521 branch May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: typescript pkg: parser PR: Bug Fix 🐛
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants