Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ts] Disallow property access after instantiation expression #14650

Merged
merged 3 commits into from Jun 27, 2022

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Jun 8, 2022

Q                       A
Fixed Issues? Ref microsoft/TypeScript#49293, microsoft/TypeScript#49464, closes #14613
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

I'm marking this as a draft until we see the actual implementation from the TS team.

@armano2 I think that after this PR we can close #14613 as "working as intended": since an instantiation expression can never appear in the middle of the chain, we can easily represent it as TSInstantiationExpression > OptionalMemberExpression (which is what we currently do).

@nicolo-ribaudo nicolo-ribaudo added PR: Spec Compliance 👓 A type of pull request used for our changelog categories pkg: parser area: typescript labels Jun 8, 2022
@nicolo-ribaudo nicolo-ribaudo marked this pull request as draft Jun 8, 2022
@babel-bot
Copy link
Collaborator

babel-bot commented Jun 8, 2022

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52375/

@nicolo-ribaudo
Copy link
Member Author

nicolo-ribaudo commented Jun 26, 2022

The TS PR has been merged.

@nicolo-ribaudo nicolo-ribaudo marked this pull request as ready for review Jun 26, 2022
@nicolo-ribaudo nicolo-ribaudo merged commit e4e700e into babel:main Jun 27, 2022
36 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the ts-49293 branch Jun 27, 2022
@JLHwung JLHwung mentioned this pull request Jul 21, 2022
1 task
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Sep 27, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Spec Compliance 👓 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants