Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove flow check scripts #14785

Merged
merged 7 commits into from Jul 24, 2022

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Jul 23, 2022

Q                       A
Any Dependency Changes? flow-bin is removed
License MIT

Removed flow check scripts now that we have converted the codebase to TypeScript.

@JLHwung JLHwung added the PR: Internal 🏠 A type of pull request used for our changelog categories label Jul 23, 2022
@babel-bot
Copy link
Collaborator

babel-bot commented Jul 23, 2022

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52594/

Makefile Show resolved Hide resolved
@@ -15,7 +13,7 @@ module.exports = {
},
env: {
node: true,
es2020: true,
es2022: true,
Copy link
Contributor Author

@JLHwung JLHwung Jul 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per https://eslint.org/docs/latest/user-guide/configuring/language-options#specifying-environments, es2022: true implies parserOptions.ecmaVersion: 2022, so I removed the former option.

Copy link
Contributor

@liuxingbaoyu liuxingbaoyu left a comment

LGTM, just wait for the CI to go green.

@nicolo-ribaudo nicolo-ribaudo merged commit acee429 into babel:main Jul 24, 2022
38 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the remove-flow-check-scripts branch Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants