Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: fix coverage for babel-cli #14965

Merged
merged 4 commits into from Sep 27, 2022
Merged

tests: fix coverage for babel-cli #14965

merged 4 commits into from Sep 27, 2022

Conversation

liuxingbaoyu
Copy link
Member

@liuxingbaoyu liuxingbaoyu commented Sep 22, 2022 •
edited

@babel-bot
Copy link
Collaborator

babel-bot commented Sep 22, 2022 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/53029/

@nicolo-ribaudo
Copy link
Member

Do you know why it doesn't work without this?

@liuxingbaoyu
Copy link
Member Author

When the process is killed, c8 has no time to collect coverage data.

@liuxingbaoyu liuxingbaoyu marked this pull request as draft September 22, 2022 14:29
@liuxingbaoyu liuxingbaoyu marked this pull request as ready for review September 22, 2022 14:40
@liuxingbaoyu
Copy link
Member Author

CI failures are out of date and have nothing to do with the current latest commit.

@nicolo-ribaudo nicolo-ribaudo changed the title fix: coverage for babel-cli tests: fix coverage for babel-cli Sep 27, 2022
@nicolo-ribaudo nicolo-ribaudo merged commit bf3b20a into babel:main Sep 27, 2022
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 28, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
area: tests outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@liuxingbaoyu @babel-bot @nicolo-ribaudo @JLHwung