Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we try to multiple ES6 module imports based on the imported source. We track the last injected import in
import-injector
and persist that memory throughout the program's transpiling lifecycle.The current implementation might break if there are external imports manipulation, i.e. users are modifying imports using tools other than
helper-module-imports
, because the injected import may not be the last import of the program and we will change the semantics when the imports have side effect. We could solve this by a new linear search to get the last import, but I think such cases are rare and we can postpone such fix to the future.