chore: Enable rule no-confusing-void-expression
#15485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuxingbaoyu
commented
Mar 11, 2023
Comment on lines
+41
to
44
| // TODO: Remove this in Babel 8 | ||
| addImport() { | ||
| return this.file.addImport(); | ||
| this.file.addImport(); | ||
| } |
There was a problem hiding this comment.
We can also remove it and file.addImport now.
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/54110/ |
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/54094/ |
nicolo-ribaudo
approved these changes
Mar 13, 2023
| @@ -629,7 +629,7 @@ export default class Scope { | |||
| if (binding) { | |||
| newName ||= this.generateUidIdentifier(oldName).name; | |||
| const renamer = new Renamer(binding, oldName, newName); | |||
| return process.env.BABEL_8_BREAKING | |||
| process.env.BABEL_8_BREAKING | |||
There was a problem hiding this comment.
Could you convert this to an if/else?
JLHwung
reviewed
Mar 13, 2023
JLHwung
approved these changes
Mar 13, 2023
Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2Initially I wanted to wait for typescript-eslint/typescript-eslint#6187 and typescript-eslint/typescript-eslint#6150 to be fixed, but today I was bothered again while reading the
parsercode, so I manually modified them.