[Babel 8] fix ignoreExtensions behaviour
#15562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
commented
Apr 12, 2023
| "sourceType": "module", | ||
| "presets": [ | ||
| ["@babel/preset-react"], | ||
| ["@babel/preset-typescript", { "allExtensions": true, "isTSX": true }] |
There was a problem hiding this comment.
The test case here is derived from babel-preset-taro's usage: https://github.com/NervJS/taro/blob/2039dce209d12c7c05b3f4b07c70dd7e598fd02f/packages/babel-preset-taro/index.js#L78-L80
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/54267/ |
nicolo-ribaudo
approved these changes
Apr 13, 2023
|
The Babel 7 part works fine previously, |
JLHwung
changed the title
ignoreExtension behaviourignoreExtensions behaviour
liuxingbaoyu
approved these changes
Apr 14, 2023
github-actions
bot
added
the
outdated
JLHwung
added
PR: Bug Fix (next major) 🐛
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ignoreExtensionsoption in Babel 8 does not work inpreset-typescript.As a follow-up to #14955, this PR fixes a bug that
ignoreExtensionsis not respected in@babel/preset-typescript. Gladly this bug has not yet been released so it hasn't affected anyone.Added
.vueas an accepted test case extension, also improved thefindFileperformance.