Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing attributes/assertions to VISITOR_KEYS #15666

Merged
merged 2 commits into from May 29, 2023
Merged

Add missing attributes/assertions to VISITOR_KEYS #15666

merged 2 commits into from May 29, 2023

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented May 29, 2023 •
edited by gitpod-io bot

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Ref prettier/prettier#14863 (comment)

@nicolo-ribaudo nicolo-ribaudo added PR: Internal 🏠 A type of pull request used for our changelog categories pkg: types labels May 29, 2023
@babel-bot
Copy link
Collaborator

babel-bot commented May 29, 2023 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/54568/

sosukesuzuki
sosukesuzuki approved these changes May 29, 2023
View reviewed changes
Copy link
Member

@sosukesuzuki sosukesuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@nicolo-ribaudo
Copy link
Member Author

I updated the PR to not change the builders parameters, so that it's internal-only.

@nicolo-ribaudo nicolo-ribaudo merged commit 579cba0 into babel:main May 29, 2023
54 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the attributes-visitor-keys branch May 29, 2023 13:28
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Aug 29, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung approved these changes

@sosukesuzuki sosukesuzuki sosukesuzuki approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: types PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nicolo-ribaudo @babel-bot @JLHwung @sosukesuzuki