chore: Run readmes.js in CI
#15690
Merged
chore: Run readmes.js in CI
#15690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuxingbaoyu
commented
Jun 8, 2023
| "babel-preset-node": "area: node", | ||
| "babel-preset-react": "area: react", | ||
| "babel-preset-typescript": "area: typescript", | ||
| "babel-parser": "pkg: parser", |
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/54638/ |
JLHwung
reviewed
Jun 9, 2023
Makefile
Outdated
| @@ -61,6 +61,7 @@ tscheck: | |||
| $(MAKEJS) tscheck | |||
|
|
|||
| lint-ci: lint check-compat-data-ci | |||
| $(NODE) scripts/generators/readmes.js | |||
There was a problem hiding this comment.
Can we add a new makefile task? e.g. make generate-readme. As it does not seem that it should be a lint task.
JLHwung
approved these changes
Jun 12, 2023
nicolo-ribaudo
approved these changes
Jun 13, 2023
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2