Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor class transform cleanups #15700

Merged
merged 2 commits into from Jun 14, 2023
Merged

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Jun 13, 2023

Q                       A
Tests Added + Pass? Yes
License MIT

Two minor cleanups about class / class properties transform:

  • The first one get rid of a @ts-expect-error comment.
  • The second one generally improves the thisContextVisitor performance as now we don't have to access the parent node for every ThisExpression node.

@JLHwung JLHwung added the PR: Internal 🏠 A type of pull request used for our changelog categories label Jun 13, 2023
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/54658/

@nicolo-ribaudo nicolo-ribaudo merged commit be094b3 into babel:main Jun 14, 2023
54 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the minor-class-cleanup branch June 14, 2023 17:37
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Sep 14, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants