Fix transform of delete a?.b
in function params
#15739
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review commit-by-commit.
The first one splits the existing transform logic in two parts, without causing any observable change:
transformOptionalChain
function)a?.b = c
in the future, which I'm presenting at the next TC39 meetingThe second commit actually fixes the bug, that I found while working on
a?.b = c
becausefunction f(x = a?.b = c) {}
was also broken.