Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: export meta from eslint-parser/experimental-worker #15747

Merged
merged 1 commit into from Jul 5, 2023

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Jul 4, 2023

Q                       A
Fixed Issues? @babel/eslint-parser/experimental-worker can not be used with flat ESLint config
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Pending integration tests with FlatESLint
Documentation PR Link
Any Dependency Changes?
License MIT

Currently ESLint will throw

ESLint: 8.44.0

Error: Could not serialize parser object (missing 'meta' object).

when the experimental worker is used with flat ESLint config. As a follow-up to #15465, in this PR we add meta info to the experimental worker.

In the future we should add integration tests with the FlatESLint class.

@JLHwung JLHwung added PR: Bug Fix 🐛 A type of pull request used for our changelog categories area: eslint labels Jul 4, 2023
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/54778/

@nicolo-ribaudo nicolo-ribaudo changed the title fix: export meta from eslint-parser worker impl fix: export meta from eslint-parser/experimental-worker Jul 5, 2023
@nicolo-ribaudo nicolo-ribaudo merged commit 7fec154 into babel:main Jul 5, 2023
55 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the add-meta-to-experimental-worker branch July 5, 2023 08:08
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 5, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: eslint outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants