Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[babel 8] Make .version directly available in cjs proxy #15809

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Jul 21, 2023

Q                       A
Fixed Issues? Fixes #15804, closes babel/babel-loader#999
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

It's not possible to easily inline it at build time because cjs-proxy.cjs is not compiled, but we can easily re-export it from package.json.

@nicolo-ribaudo nicolo-ribaudo changed the title Make .version directly available in cjs proxy for ESM build [babel 8] Make .version directly available in cjs proxy Jul 21, 2023
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/54923/

@nicolo-ribaudo nicolo-ribaudo merged commit 1010563 into babel:main Jul 21, 2023
57 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the cjs-proxy-version branch July 21, 2023 14:01
@JLHwung JLHwung added PR: Polish (next major) 💅 A type of pull request used for our changelog categories for next major release and removed babel 8 labels Aug 9, 2023
@JLHwung JLHwung added this to the v8.0.0 milestone Aug 9, 2023
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Polish (next major) 💅 A type of pull request used for our changelog categories for next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[babel 8]: Does not work with babel-loader
4 participants