Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid dynamic dispatch when calling wrapCheck #16060

Merged
merged 4 commits into from Oct 25, 2023
Merged

Avoid dynamic dispatch when calling wrapCheck #16060

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dd87b2d
Avoid dynamic dispatch when calling wrapCheck
yepitschunked Oct 24, 2023
75638c0
Update visitors.ts
yepitschunked Oct 24, 2023
d52a872
Update visitors.ts
yepitschunked Oct 24, 2023
0c9a94a
Update visitors.ts
yepitschunked Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/babel-traverse/src/visitors.ts
View file
Open in desktop
@@ -1,4 +1,5 @@
import * as virtualTypes from "./path/lib/virtual-types.ts";
import * as virtualTypesValidators from "./path/lib/virtual-types-validator.ts";
import type { Node } from "@babel/types";
import {
DEPRECATED_KEYS,
Expand Down Expand Up @@ -330,9 +331,11 @@ function ensureCallbackArrays(obj: Visitor) {
}

function wrapCheck(nodeType: VIRTUAL_TYPES, fn: Function) {
const fnKey = `is${nodeType}`;
// @ts-expect-error we know virtualTypesValidators will contain `fnKey`, but TS doesn't
const validator = virtualTypesValidators[fnKey];
const newFn = function (this: unknown, path: NodePath) {
// @ts-expect-error: Expression produces a union type that is too complex to represent.
if (path[`is${nodeType}`]()) {
if (validator.call(path)) {
return fn.apply(this, arguments);
}
};
Expand Down