Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix indentation when generating comments with concise: true #16078

Merged
merged 2 commits into from Nov 3, 2023
Merged

Fix indentation when generating comments with concise: true #16078

merged 2 commits into from Nov 3, 2023

Conversation

liuxingbaoyu
Copy link
Member

Q                       A
Fixed Issues? Fixes #16077
Patch: Bug Fix? √
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? √
Documentation PR Link
Any Dependency Changes?
License MIT

@liuxingbaoyu liuxingbaoyu added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: generator labels Oct 31, 2023
@babel-bot
Copy link
Collaborator

babel-bot commented Oct 31, 2023 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/55763/

nicolo-ribaudo
nicolo-ribaudo reviewed Nov 2, 2023
View reviewed changes
packages/babel-generator/test/fixtures/comments/concise-block-comment-indent/input.js
@@ -0,0 +1,3 @@
"1111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111";/**
x
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a case in which the comment should be indented? Like

{
  "1111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111";/**
              x
  */
}

@nicolo-ribaudo nicolo-ribaudo changed the title fix: Wrong indentation when generating comments when concise: true Fix indentation when generating comments with concise: true Nov 3, 2023
@nicolo-ribaudo nicolo-ribaudo merged commit 917010d into babel:main Nov 3, 2023
45 of 48 checks passed
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Feb 3, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: generator PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: RangeError: Invalid string length
4 participants
@liuxingbaoyu @babel-bot @JLHwung @nicolo-ribaudo