New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify class fields injetion after super()
#16123
Merged
nicolo-ribaudo
merged 2 commits into
babel:main
from
nicolo-ribaudo:multiple-super-in-ternary
Nov 25, 2023
Merged
Simplify class fields injetion after super()
#16123
nicolo-ribaudo
merged 2 commits into
babel:main
from
nicolo-ribaudo:multiple-super-in-ternary
Nov 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
PR: Bug Fix 🐛
A type of pull request used for our changelog categories
Spec: Class Fields
labels
Nov 24, 2023
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/55867/ |
JLHwung
approved these changes
Nov 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat.👍
liuxingbaoyu
approved these changes
Nov 25, 2023
TypeScript is wrong — class fields must be initialised after calling super. |
Vylpes
pushed a commit
to Vylpes/random-bunny
that referenced
this pull request
Dec 4, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@babel/traverse](https://babel.dev/docs/en/next/babel-traverse) ([source](https://github.com/babel/babel)) | resolutions | patch | [`7.23.3` -> `7.23.5`](https://renovatebot.com/diffs/npm/@babel%2ftraverse/7.23.3/7.23.5) | --- ### Release Notes <details> <summary>babel/babel (@​babel/traverse)</summary> ### [`v7.23.5`](https://github.com/babel/babel/blob/HEAD/CHANGELOG.md#v7235-2023-11-29) [Compare Source](babel/babel@v7.23.4...v7.23.5) ##### 👓 Spec Compliance - `babel-plugin-proposal-decorators` - [#​16138](babel/babel#16138) Class binding is in TDZ during decorators initialization ([@​nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - `babel-helpers`, `babel-plugin-proposal-decorators` - [#​16132](babel/babel#16132) Allow addInitializer in field decorator context ([@​JLHwung](https://github.com/JLHwung)) ##### 🐛 Bug Fix - `babel-traverse`, `babel-types` - [#​16131](babel/babel#16131) Do not remove bindings when removing assignment expression path ([@​nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - `babel-plugin-transform-classes` - [#​16135](babel/babel#16135) Require class properties transform when compiling class with private fields ([@​nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - `babel-generator` - [#​16122](babel/babel#16122) fix: Missing parentheses after line break ([@​liuxingbaoyu](https://github.com/liuxingbaoyu)) - `babel-helpers` - [#​16130](babel/babel#16130) Fix helpers internal fns names conflict resolution ([@​nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - `babel-helper-create-class-features-plugin`, `babel-plugin-transform-class-properties`, `babel-plugin-transform-typescript` - [#​16123](babel/babel#16123) Simplify class fields injetion after `super()` ([@​nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - `babel-generator`, `babel-plugin-transform-modules-commonjs`, `babel-plugin-transform-parameters`, `babel-plugin-transform-typescript`, `babel-traverse` - [#​16110](babel/babel#16110) fix: Unexpected duplication of comments ([@​liuxingbaoyu](https://github.com/liuxingbaoyu)) - `babel-eslint-plugin` - [#​16023](babel/babel#16023) Add `@babel/eslint-plugin/no-undef` to fix `no-undef` with accessor props ([@​nicolo-ribaudo](https://github.com/nicolo-ribaudo)) ##### 🔬 Output optimization - `babel-helpers` - [#​16129](babel/babel#16129) Optimize `decorator` helper size ([@​liuxingbaoyu](https://github.com/liuxingbaoyu)) ### [`v7.23.4`](https://github.com/babel/babel/blob/HEAD/CHANGELOG.md#v7234-2023-11-20) [Compare Source](babel/babel@v7.23.3...v7.23.4) ##### 🐛 Bug Fix - `babel-generator` - [#​16104](babel/babel#16104) fix: Pure comments missing parentheses ([@​liuxingbaoyu](https://github.com/liuxingbaoyu)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4wLjAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4wLjAiLCJ0YXJnZXRCcmFuY2giOiJkZXZlbG9wIn0=--> Reviewed-on: https://gitea.vylpes.xyz/RabbitLabs/random-bunny/pulls/113 Reviewed-by: Vylpes <ethan@vylpes.com> Co-authored-by: Renovate Bot <renovate@vylpes.com> Co-committed-by: Renovate Bot <renovate@vylpes.com>
github-actions
bot
added
the
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
label
Feb 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
PR: Bug Fix 🐛
A type of pull request used for our changelog categories
Spec: Class Fields
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was caused by some missing cloning of nodes. This PR avoids the problem by simplifying how we inject nodes after
super()
in expressions, so that cloning is not needed at all.