Remove `TSPropertySignature.initializer` #16154

fisker · 2023-12-05T10:56:12Z

Ref: prettier/prettier#14264
Ref: typescript-eslint/typescript-eslint#6243 (comment)

Q	A
Fixed Issues?	`Fixes #1, Fixes #2`
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass?	Yes
Documentation PR Link
Any Dependency Changes?
License	MIT

babel-bot · 2023-12-05T10:58:18Z

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/55966/

nicolo-ribaudo · 2023-12-05T11:06:56Z

Do we currently throw when parsing the equivalent code?

fisker · 2023-12-05T11:16:24Z

I think so?

https://github.com/prettier/prettier/pull/14264/files#diff-617f88f1112fb243319fe380e96490e347d7b2613caed8bb24c87669669babafR3

> require('@babel/parser').parse('interface I { x: number = 1;}', {plugins:['typescript']})
Uncaught [SyntaxError: Unexpected token, expected ";" (1:24)
] {
  code: 'BABEL_PARSER_SYNTAX_ERROR',
  reasonCode: 'UnexpectedToken',
  loc: Position { line: 1, column: 24, index: 24 },
  pos: 24
}
> require('@babel/parser').parse('interface I { x: number = 1;}', {plugins:['typescript'], errorRecovery: true})
Uncaught [SyntaxError: Unexpected token, expected ";" (1:24)
] {
  code: 'BABEL_PARSER_SYNTAX_ERROR',
  reasonCode: 'UnexpectedToken',
  loc: Position { line: 1, column: 24, index: 24 },
  pos: 24
}

liuxingbaoyu

Thanks!

liuxingbaoyu · 2023-12-06T03:33:49Z

This is technically a breaking change, but I guess no one needs it. Mark this as PR: Spec Compliance 👓 I think it's fine.

liuxingbaoyu · 2023-12-06T03:39:30Z

packages/babel-parser/src/types.d.ts

@@ -1345,7 +1345,6 @@ export interface TsPropertySignature extends TsNamedTypeElementBase {
  type: "TSPropertySignature";
  readonly?: true;
  typeAnnotation?: TsTypeAnnotation;
-  initializer?: Expression;


I checked the parser and it should not be actually used.

Thanks, sorry that I missed.

It doesn't matter, thank you for any contribution! I leave this review just to facilitate other reviewers. :)

nicolo-ribaudo · 2023-12-11T11:00:17Z

Yeah I'm fine with merging this in a patch. There is no way to generate this AST through @babel/parser, and if you are manually building this AST we should not let the user assume that it represents valid code.

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@babel/traverse](https://babel.dev/docs/en/next/babel-traverse) ([source](https://github.com/babel/babel)) | resolutions | patch | [`7.23.5` -> `7.23.7`](https://renovatebot.com/diffs/npm/@babel%2ftraverse/7.23.5/7.23.7) | --- ### Release Notes <details> <summary>babel/babel (@babel/traverse)</summary> ### [`v7.23.7`](https://github.com/babel/babel/blob/HEAD/CHANGELOG.md#v7237-2023-12-29) [Compare Source](babel/babel@v7.23.6...v7.23.7) ##### 🐛 Bug Fix - `babel-traverse` - [#16191](babel/babel#16191) fix: Crash when removing without `Program` ([@liuxingbaoyu](https://github.com/liuxingbaoyu)) - `babel-helpers`, `babel-plugin-proposal-decorators` - [#16180](babel/babel#16180) fix: Class decorator `ctx.kind` is wrong ([@liuxingbaoyu](https://github.com/liuxingbaoyu)) - `babel-plugin-proposal-decorators` - [#16170](babel/babel#16170) Fix decorator initProto usage in derived classes ([@JLHwung](https://github.com/JLHwung)) - `babel-core` - [#16167](babel/babel#16167) Avoid unpreventable `unhandledRejection` events ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) ##### 🏠 Internal - `babel-helper-create-class-features-plugin` - [#16186](babel/babel#16186) chore: Update deps ([@liuxingbaoyu](https://github.com/liuxingbaoyu)) - `babel-helper-create-class-features-plugin`, `babel-plugin-proposal-decorators` - [#16177](babel/babel#16177) Merge decorators into class features ([@JLHwung](https://github.com/JLHwung)) ### [`v7.23.6`](https://github.com/babel/babel/blob/HEAD/CHANGELOG.md#v7236-2023-12-11) [Compare Source](babel/babel@v7.23.5...v7.23.6) ##### 👓 Spec Compliance - `babel-generator`, `babel-parser`, `babel-types` - [#16154](babel/babel#16154) Remove `TSPropertySignature.initializer` ([@fisker](https://github.com/fisker)) - `babel-helpers`, `babel-plugin-proposal-decorators`, `babel-plugin-transform-class-properties`, `babel-plugin-transform-class-static-block`, `babel-plugin-transform-runtime`, `babel-preset-env`, `babel-runtime-corejs2`, `babel-runtime-corejs3`, `babel-runtime`, `babel-types` - [#16139](babel/babel#16139) Apply `toPropertyKey` on decorator context name ([@JLHwung](https://github.com/JLHwung)) ##### 🐛 Bug Fix - `babel-generator` - [#16166](babel/babel#16166) fix: Correctly indenting when `retainLines` is enabled ([@liuxingbaoyu](https://github.com/liuxingbaoyu)) - `babel-helpers`, `babel-plugin-proposal-explicit-resource-management` - [#16150](babel/babel#16150) `using`: Allow looking up `Symbol.dispose` on a function ([@odinho](https://github.com/odinho)) - `babel-plugin-proposal-decorators`, `babel-plugin-transform-class-properties` - [#16161](babel/babel#16161) Ensure the `[[@@toPrimitive]]` call of a decorated class member key is invoked once ([@JLHwung](https://github.com/JLHwung)) - [#16148](babel/babel#16148) Support named evaluation for decorated anonymous class exp ([@JLHwung](https://github.com/JLHwung)) - `babel-plugin-transform-for-of`, `babel-preset-env` - [#16011](babel/babel#16011) fix: `for of` with `iterableIsArray` and shadowing variable ([@liuxingbaoyu](https://github.com/liuxingbaoyu)) - `babel-helpers`, `babel-plugin-proposal-decorators`, `babel-runtime-corejs2`, `babel-runtime-corejs3`, `babel-runtime` - [#16144](babel/babel#16144) Set function name for decorated private non-field elements ([@JLHwung](https://github.com/JLHwung)) - `babel-plugin-transform-typescript` - [#16137](babel/babel#16137) Fix references to enum values with merging ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) ##### 🔬 Output optimization - `babel-helper-create-class-features-plugin`, `babel-plugin-transform-class-properties` - [#16159](babel/babel#16159) Reuse computed key memoiser ([@JLHwung](https://github.com/JLHwung)) - `babel-helpers`, `babel-plugin-proposal-decorators` - [#16160](babel/babel#16160) Optimize decorator helper size ([@liuxingbaoyu](https://github.com/liuxingbaoyu)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.vylpes.xyz/RabbitLabs/random-bunny/pulls/129 Co-authored-by: Renovate Bot <renovate@vylpes.com> Co-committed-by: Renovate Bot <renovate@vylpes.com>

Remove TSPropertySignature.initializer

ae856d8

fisker added 2 commits December 5, 2023 11:03

Commit generated files

a5a26ae

Remove from generator

7121239

fisker marked this pull request as ready for review December 5, 2023 11:21

Add test

5a577bd

fisker marked this pull request as draft December 5, 2023 11:24

Commit parse result

916dced

fisker marked this pull request as ready for review December 5, 2023 11:33

liuxingbaoyu approved these changes Dec 6, 2023

View reviewed changes

liuxingbaoyu added PR: Spec Compliance 👓 A type of pull request used for our changelog categories pkg: generator area: typescript labels Dec 6, 2023

parser types

c2ae39d

liuxingbaoyu reviewed Dec 6, 2023

View reviewed changes

JLHwung approved these changes Dec 6, 2023

View reviewed changes

nicolo-ribaudo changed the title ~~Remove TSPropertySignature.initializer~~ Remove TSPropertySignature.initializer Dec 11, 2023

nicolo-ribaudo merged commit e9a74bc into babel:main Dec 11, 2023
48 checks passed

fisker deleted the TSPropertySignature-initializer branch December 14, 2023 22:36

github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Mar 15, 2024

github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove `TSPropertySignature.initializer` #16154

Remove `TSPropertySignature.initializer` #16154

fisker commented Dec 5, 2023 •

edited

babel-bot commented Dec 5, 2023 •

edited

nicolo-ribaudo commented Dec 5, 2023

fisker commented Dec 5, 2023

liuxingbaoyu left a comment

liuxingbaoyu commented Dec 6, 2023

liuxingbaoyu Dec 6, 2023

fisker Dec 6, 2023

liuxingbaoyu Dec 6, 2023

nicolo-ribaudo commented Dec 11, 2023 •

edited

Remove TSPropertySignature.initializer #16154

Remove TSPropertySignature.initializer #16154

Conversation

fisker commented Dec 5, 2023 • edited

babel-bot commented Dec 5, 2023 • edited

nicolo-ribaudo commented Dec 5, 2023

fisker commented Dec 5, 2023

liuxingbaoyu left a comment

Choose a reason for hiding this comment

liuxingbaoyu commented Dec 6, 2023

liuxingbaoyu Dec 6, 2023

Choose a reason for hiding this comment

fisker Dec 6, 2023

Choose a reason for hiding this comment

liuxingbaoyu Dec 6, 2023

Choose a reason for hiding this comment

nicolo-ribaudo commented Dec 11, 2023 • edited

Remove `TSPropertySignature.initializer` #16154

Remove `TSPropertySignature.initializer` #16154

fisker commented Dec 5, 2023 •

edited

babel-bot commented Dec 5, 2023 •

edited

nicolo-ribaudo commented Dec 11, 2023 •

edited