-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve super.x
output
#16374
base: main
Are you sure you want to change the base?
Improve super.x
output
#16374
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57350 |
Finally reviewing this, sorry it took so long.
This is covered by the Can you add a test for the execution order between property access and arguments evaluation? let argsEval = false;
let err = {};
class A {
get x() { throw {} }
}
class B extends A {
method() {
super.x(argsEval = true);
}
}
expect(() => new B().method()).toThrow(err);
expect(argsEval).toBe(false); |
dd1bc89
to
92e2168
Compare
9c609ac
to
8cb4293
Compare
Fixes #1, Fixes #2
I personally don't like having to call
![image](https://private-user-images.githubusercontent.com/30521560/315286591-31079817-1ac8-493d-84c6-131a3ef7e833.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE2NTc2NDcsIm5iZiI6MTcyMTY1NzM0NywicGF0aCI6Ii8zMDUyMTU2MC8zMTUyODY1OTEtMzEwNzk4MTctMWFjOC00OTNkLTg0YzYtMTMxYTNlZjdlODMzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIyVDE0MDkwN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTk1NzM5MTZmMjNjNDEzMTMwMGEyMWUxOWRmODE1NzgxNDNhMmM3ZjUwYzNiMjU3YmU1YTJlOWY4Yjc0N2E1N2ImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.W_Dhi_x8Ydg_kb3f1QCOkJrfyq4AB-8eyoOv2j-IeeM)
getPrototypeOf
every time because it's slow, but we have a test that relies on this behavior.