-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove syntaxType
option for record-and-tuple (parser&plugin)
#16458
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/56799 |
7f6d472
to
71f94b0
Compare
@@ -27,6 +27,8 @@ if [ "$BABEL_8_BREAKING" = true ] ; then | |||
sed -i 's/const generate = babelGenerator.default/const generate = babelGenerator/' scripts/build/transform/index.js | |||
sed -i 's/,"updateContext":null//g' tests/integration/__tests__/__snapshots__/debug-print-ast.js.snap | |||
rm tests/unit/__snapshots__/visitor-keys.js.snap | |||
# Update recordAndTuple usage | |||
sed -i 's/\["recordAndTuple", { syntaxType: "hash" }\]/"recordAndTuple"/' src/language-js/parse/babel.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @fisker We plan to remove the syntaxType
option in Babel 8. The syntax will always be hash.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
syntaxType
option from the record-and-tuple plugin and babel parsersyntaxType
option for record-and-tuple (parser&plugin)
In this PR we remove the
syntaxType
option from the@babel/plugin-proposal-record-and-tuple
and the Babel parser pluginrecordAndTuple
for Babel 8.I suggest we deprecate
syntaxType: "bar"
and default tosyntaxType: "hash"
starting from Babel 7.25, as users will have longer time window to migrate to the hash syntax or update their Babel configs.