Do not use strict mode in TS declare
#16567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuxingbaoyu
added
PR: Spec Compliance 👓
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57162 |
| ) { | ||
| let oldStrict; | ||
| if (this.state.isAmbientContext && this.state.strict) { | ||
| oldStrict = this.state.strict; |
There was a problem hiding this comment.
Suggested change
| oldStrict = this.state.strict; | |
| oldStrict = true; |
There was a problem hiding this comment.
Or can we change the strictness when entering the ambient context, rather than when checking the identifier?
There was a problem hiding this comment.
Or can we change the strictness when entering the ambient context, rather than when checking the identifier?
nicolo-ribaudo
approved these changes
Jun 8, 2024
JLHwung
approved these changes
Jun 10, 2024
nicolo-ribaudo
changed the title
declaredeclare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if it would be better to modify
packages\babel-parser\src\parser\lval.tsdirectly, that would be faster and simpler.