[helpers TS conversion] subclasses #16578
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amjed-98
changed the title
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57232 |
13 tasks
JLHwung
approved these changes
Jul 2, 2024
| function Wrapper() { | ||
| // @ts-expect-error -- where are sure Class is a function here |
There was a problem hiding this comment.
Suggested change
| // @ts-expect-error -- where are sure Class is a function here | |
| // @ts-expect-error -- we are sure Class is a function here |
| var _cache = typeof Map === "function" ? new Map() : undefined; | ||
|
|
||
| _wrapNativeSuper = function _wrapNativeSuper(Class) { | ||
| // @ts-expect-error -- test |
There was a problem hiding this comment.
Suggested change
| // @ts-expect-error -- test | |
| // @ts-expect-error -- reuse function id for helper size |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate subclasses helpers to typescript (callSuper, inherits, inheritsLoose, isNativeFunction, wrapNativeSuper)