fix: fix declarator removal only deletes one binding #16584
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As specified above, this PR fixes a problem where removing the only
VariableDeclarator
of aVariableDeclaration
node leads to removal (or at least attempt) of 2 Bindings with the same name from different scopes (the removal of the declarator removes the correct binding, but the removal of the declaration attempts to remove it again, and if it finds it in a parent scope, it deletes it from there too)The current solution is a HOTFIX and documented as such in the comments of the typescript code. I am open to suggestions for making it better.