Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for mixins to Babel 6.x #3203

Merged
merged 6 commits into from
Dec 27, 2015
Merged

Conversation

samwgoldman
Copy link
Contributor

If this looks good I'll backport to Babel 5.x. In particular I'm unsure if it's kosher to reuse InterfaceExtends as the type of mixins nodes. Should I create a ClassMixins type instead?

cc @sebmck @jeffmo

@samwgoldman
Copy link
Contributor Author

I forgot to add the necessary generator behaviors. Fixing now...

@samwgoldman
Copy link
Contributor Author

OK, GTG.

@codecov-io
Copy link

Current coverage is 84.90%

Merging #3203 into master will decrease coverage by -0.19% as of 5cfec9d

@@            master   #3203   diff @@
======================================
  Files          215     215       
  Stmts        15617   15618     +1
  Branches      3341    3343     +2
  Methods          0       0       
======================================
- Hit          13289   13260    -29
- Partial        681     711    +30
  Missed        1647    1647       

Review entire Coverage Diff as of 5cfec9d

Powered by Codecov. Updated on successful CI builds.

@jamiebuilds
Copy link
Contributor

All these changes to flow stuff need updates in:

@@ -104,6 +104,10 @@ export function _interfaceish(node: Object) {
this.push(" extends ");
this.printJoin(node.extends, node, { separator: ", " });
}
if (node.mixins.length) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need a node.mixins existence check here too.

@samwgoldman
Copy link
Contributor Author

@thejameskyle I think I addressed your comment, but can you confirm?

@sebmck
Copy link
Contributor

sebmck commented Dec 24, 2015

There's still a missing mixins visitor key that will need to be added here.

sebmck added a commit that referenced this pull request Dec 27, 2015
Add support for mixins to Babel 6.x
@sebmck sebmck merged commit 5ca1cf0 into babel:master Dec 27, 2015
JacopKane pushed a commit to JacopKane/babel that referenced this pull request Jan 11, 2018
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants