-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for mixins to Babel 6.x #3203
Conversation
I forgot to add the necessary generator behaviors. Fixing now... |
OK, GTG. |
Current coverage is
|
All these changes to flow stuff need updates in:
|
@@ -104,6 +104,10 @@ export function _interfaceish(node: Object) { | |||
this.push(" extends "); | |||
this.printJoin(node.extends, node, { separator: ", " }); | |||
} | |||
if (node.mixins.length) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need a node.mixins
existence check here too.
@thejameskyle I think I addressed your comment, but can you confirm? |
There's still a missing |
Add support for mixins to Babel 6.x
Add support for mixins to Babel 6.x
If this looks good I'll backport to Babel 5.x. In particular I'm unsure if it's kosher to reuse
InterfaceExtends
as the type ofmixins
nodes. Should I create aClassMixins
type instead?cc @sebmck @jeffmo