Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename babel-plugin-external-helpers-2 to babel-plugin-external-helpers #3205

Merged
merged 1 commit into from
Dec 24, 2015
Merged

Rename babel-plugin-external-helpers-2 to babel-plugin-external-helpers #3205

merged 1 commit into from
Dec 24, 2015

Conversation

sebmck
Copy link
Contributor

@sebmck sebmck commented Dec 24, 2015

Merging after CI as this is a noncontroversial change. Added all existing babel package owners as npm owners too.

@sebmck sebmck mentioned this pull request Dec 24, 2015
Closed
@jamiebuilds
Copy link
Contributor

why was this named external-helpers-2 in the first place?

@sebmck
Copy link
Contributor Author

sebmck commented Dec 24, 2015

because someone else had the babel-plugin-external-helpers package

@codecov-io
Copy link

Current coverage is 84.88%

Merging #3205 into master will decrease coverage by -0.21% as of 1fa24b1

@@            master   #3205   diff @@
======================================
  Files          215     215       
  Stmts        15617   15617       
  Branches      3341    3341       
  Methods          0       0       
======================================
- Hit          13289   13257    -32
- Partial        682     714    +32
  Missed        1646    1646

Review entire Coverage Diff as of 1fa24b1

Powered by Codecov. Updated on successful CI builds.

sebmck added a commit that referenced this pull request Dec 24, 2015
@sebmck
Merge pull request #3205 from babel/external-helpers
5b091c1 
Rename babel-plugin-external-helpers-2 to babel-plugin-external-helpers
@sebmck sebmck merged commit 5b091c1 into master Dec 24, 2015
@sebmck sebmck deleted the external-helpers branch December 24, 2015 04:09
prathamesh-sonpatki added a commit to prathamesh-sonpatki/babel.github.io that referenced this pull request Dec 27, 2015
@prathamesh-sonpatki
Renamed babel-plugin-external-helpers-plugin-2 to babel-plugin-extern…
f79ae2b 
…al-helpers-plugin

Ref - babel/babel#3205
- Fixes babel#81
@prathamesh-sonpatki prathamesh-sonpatki mentioned this pull request Dec 27, 2015
Merged
prathamesh-sonpatki added a commit to prathamesh-sonpatki/babel.github.io that referenced this pull request Dec 27, 2015
@prathamesh-sonpatki
Renamed babel-plugin-external-helpers-2 to babel-plugin-external-helpers
5649cf9 
Ref - babel/babel#3205
- Fixes babel#81
@hzoo hzoo mentioned this pull request Dec 31, 2015
Closed
@ericf ericf mentioned this pull request Jan 7, 2016
Closed
@rtsao rtsao mentioned this pull request Oct 21, 2016
Merged
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sebmck @jamiebuilds @codecov-io