Use only regexpu-core instead of all of regexpu
#3259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -11,4 +11,4 @@ export default function () { | |||
| } | |||
| } | |||
| }; | |||
| } | |||
| }; | |||
There was a problem hiding this comment.
FTR, this semicolon to be missing from most plugins.
|
Awesome! Thank you for this |
| @@ -1,4 +1,4 @@ | |||
| import rewritePattern from "regexpu/rewrite-pattern"; | |||
| import * as rewritePattern from "regexpu-core"; | |||
There was a problem hiding this comment.
This needs to be:
import rewritePattern from "regexpu-core";since rewritePattern is the default export
|
Thank you for showing me the way ;) I suppose we don’t need a separate babel-plugin-regexpu anymore? |
|
Those modules were never published so I'll just delete the repos. |
Current coverage is
|
jamiebuilds
added a commit
that referenced
this pull request
Jan 11, 2016
Use only `regexpu-core` instead of all of `regexpu`
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. mathiasbynens/regexpu#24.
regexpu’s use of
esprimaandrecastis not needed for Babel. Removing them decreases the npm download size by about 1.5 MB.cc @thejameskyle