New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip flow-only class props without needing transform-class-properties. #3655

Merged
merged 1 commit into from Aug 16, 2016

Conversation

Projects
None yet
3 participants
@loganfsmyth
Member

loganfsmyth commented Aug 14, 2016

Alternate fix for #3654

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Aug 14, 2016

Current coverage is 88.13% (diff: 100%)

Merging #3655 into master will not change coverage

@@             master      #3655   diff @@
==========================================
  Files           188        188          
  Lines         10925      10925          
  Methods        1162       1162          
  Messages          0          0          
  Branches       2492       2492          
==========================================
  Hits           9629       9629          
  Misses         1296       1296          
  Partials          0          0          

Powered by Codecov. Last update a615964...b8df9ed

codecov-io commented Aug 14, 2016

Current coverage is 88.13% (diff: 100%)

Merging #3655 into master will not change coverage

@@             master      #3655   diff @@
==========================================
  Files           188        188          
  Lines         10925      10925          
  Methods        1162       1162          
  Messages          0          0          
  Branches       2492       2492          
==========================================
  Hits           9629       9629          
  Misses         1296       1296          
  Partials          0          0          

Powered by Codecov. Last update a615964...b8df9ed

@hzoo

This comment has been minimized.

Show comment
Hide comment
@hzoo

hzoo Aug 14, 2016

Member

@loganfsmyth looks good.

Do we want to add a test for the other case in the logic (a class property with annotation that only removes the annotation)?

Member

hzoo commented Aug 14, 2016

@loganfsmyth looks good.

Do we want to add a test for the other case in the logic (a class property with annotation that only removes the annotation)?

@hzoo hzoo added this to the Next Patch milestone Aug 14, 2016

@hzoo hzoo merged commit 2aaee8b into babel:master Aug 16, 2016

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing a615964...b8df9ed
Details
codecov/project 88.13% (+0.00%) compared to a615964
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment