Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(shouldIgnore): filename normalization should be platform sensitive #4631

Merged
merged 4 commits into from
Oct 11, 2016
Merged

fix(shouldIgnore): filename normalization should be platform sensitive #4631

merged 4 commits into from
Oct 11, 2016

Commits on Oct 1, 2016

  1. fix(shouldIgnore): filename normalization should be platform sensitive 

    shouldIgnore normalizes the path of the filename prior to running any "only" regexes or functions. The normalization uses "slash", which has some undesirable special cases for non-ASCII characters and longer paths. Changing the normalization behavior to always replace path separators.

There is no real need to add additional tests, because the tests are not run in an environment where path.sep !== '/'.
    @rozele
    rozele committed Oct 1, 2016
    Configuration menu
    Copy the full SHA
    2f3ed30 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2016

  1. Minor style fix to use double quotes.

    @rozele
    rozele committed Oct 3, 2016
    Configuration menu
    Copy the full SHA
    3a6c8f6 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2016

  1. Remove conditional for regex replace to keep consistent behavior.

    @rozele
    rozele committed Oct 11, 2016
    Configuration menu
    Copy the full SHA
    137c808 View commit details
    Browse the repository at this point in the history

  2. whitespace [skip ci]

    @hzoo
    hzoo committed Oct 11, 2016
    Configuration menu
    Copy the full SHA
    37e55a6 View commit details
    Browse the repository at this point in the history