Preserve null in babel-types' clone and deepClone. #4853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 89.36% (diff: 100%)
|
|
Cool - what about a test case for a node that contains null for deepClone and I assume undefined is good? |
hzoo
added
the
PR: Bug Fix 🐛
|
I would add your original test case in the tests? |
Adding tests. Updating last test to reflect original test case [,0]
|
Thanks for the feedback! I updated the implementation to also handle undefined, and added tests for top-level undefined and nested explicit null. However, I don't think there is any valid nested place for undefined --- if you know one, I could add a test for it. Otherwise, as far as I know, null is really the only special value where things went wrong before. |
|
Awesome! Thanks for contributing 👌 |
panagosg7
pushed a commit
to panagosg7/babel
that referenced
this pull request
Jan 17, 2017
* Preserve null in babel-types' clone and deepClone. * Also respect undefined when cloning. * Updating last test to reflect original test case "[,0]"
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preserve null in babel-types' clone and deepClone.
(The current behavior turns null into {}, which is not equivalent. Null is a valid expression used to represent missing array elements. The Printer in particular cannot generate code for {}, but it does handle null.)
Add tests.