Extend babel-template to work as a template tag #5001
Conversation
| } else { | ||
| return template(firstArg, ...rest); | ||
| } | ||
| } |
There was a problem hiding this comment.
I tried making a separate export instead, but that would be a breaking change because of add-module-exports.
Can we get rid of it? 🙂
Current coverage is 89.14% (diff: 98.14%)
|
hzoo
added
the
PR: New Feature 🚀
packages/babel-template/src/index.js
Outdated
| } | ||
|
|
||
| function template (partials: Object | string[], ...args: Array<Object>) { | ||
| if (!Array.isArray(partials)) { |
There was a problem hiding this comment.
Should we throw if args.length > 0 for this case to help in case people mistype something?
| } | ||
|
|
||
| if (typeof arg === "number") { | ||
| replacementMap.set(arg, `$${arg}`); |
There was a problem hiding this comment.
Do we want $BABEL_TEMPLATE$ on this too? Or is this already an assumption with the current template implementation?
There was a problem hiding this comment.
This is using the current implementation's positional argument replacement.
It is validated that 0 cannot be used if named arguments are used too, but I forgot to check for /$\d+/ in the string parts themselves...
|
I think this would be a great addition for 7.x, @Kovensky Would you have time to fix the conflict? |
Supports:
```js
// these all should produce "code;" when generated
template`code;`();
template`${0}`(t.identifier('code'));
template`${'code'}`({ code: t.identifier('code') });
template`${t.identifier('code')}`()
template({})`code`();
```
Jessidhia
force-pushed
the
babel-template-template
branch
from
7d6a6fc
to
19dfe64
Compare
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/5183/ |
|
This is a great addition IMO, can it be documented in the README? |
|
Yea we should make an issue about it; it can go in the 7.x post too #6388 |
lock
bot
added
the
outdated
Supports: