Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid duplicating impure expressions in object rest destructuring #5151

Merged
merged 2 commits into from
Jan 19, 2017
Merged

Avoid duplicating impure expressions in object rest destructuring #5151

merged 2 commits into from
Jan 19, 2017

Commits on Jan 18, 2017

  1. avoid duplicating impure initializers in object rest destructuring

    @erikdesjardins
    erikdesjardins committed Jan 18, 2017
    Configuration menu
    Copy the full SHA
    8b6b8ee View commit details
    Browse the repository at this point in the history

  2. reuse existing VariableDeclarations in object rest destructuring, to … 

    …fix two issues:

1. inserting an additional VariableDeclaration after the current one may change order of operations, which is unsafe if a future VariableDeclarator refers to a destructured variable.

2. The entire VariableDeclaration is removed when all properties are rest properties, indiscriminately removing other variables
    @erikdesjardins
    erikdesjardins committed Jan 18, 2017
    Configuration menu
    Copy the full SHA
    433eade View commit details
    Browse the repository at this point in the history