Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added yarn.lock #5175

Merged
merged 4 commits into from Jan 23, 2017
Merged

Added yarn.lock #5175

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bff08c3
Added yarn.lock
cnguy Jan 20, 2017
37cca8b
Updated bootstrap npm install commands to yarn and added yarn caching
cnguy Jan 20, 2017
b16f9cb
Merge branch '7.0' of https://github.com/babel/babel into add-yarn-lock
cnguy Jan 21, 2017
bcb4698
Fixed branch
cnguy Jan 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .travis.yml
View file
Open in desktop
Expand Up @@ -3,6 +3,7 @@ git:
sudo: false
language: node_js
cache:
yarn: true
directories:
- node_modules
node_js:
Expand Down
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Expand Up @@ -72,9 +72,9 @@ publish:

bootstrap:
make clean-all
npm install
yarn
./node_modules/.bin/lerna bootstrap
make build
cd packages/babel-runtime; \
npm install; \
yarn; \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what we should do here - actually wondering why bootstrap doesn't cover npm install in babel-runtime anyway..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that doesn't make much sense.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I remember now.

babel/lerna.json

Lines 16 to 17 in d76092b

"bootstrapConfig": {
"ignore": "babel-runtime"

we ignore it explicitly because of babel-runtime in every package and having babel-runtime as a package itself so we had to move it up to the top level package.json. Hopefully when we remove we don't have to do this.

Copy link
Member

@hzoo hzoo Jan 21, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How bout we keep npm install for this for now? I don't think we want a lock file in packages/babel-runtime and we will try to fix this via the other issue #5118

node scripts/build-dist.js