Ensure babel-cli tests compare generated output with out-files #5205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
existentialism
added
the
PR: Internal 🏠
|
@existentialism, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hzoo, @DrewML and @zertosh to be potential reviewers. |
Codecov Report
@@ Coverage Diff @@
## 7.0 #5205 +/- ##
==========================================
+ Coverage 85.39% 85.43% +0.04%
==========================================
Files 201 201
Lines 9483 9483
Branches 2688 2688
==========================================
+ Hits 8098 8102 +4
+ Misses 892 890 -2
+ Partials 493 491 -2
Continue to review full report at Codecov.
|
xtuc
reviewed
Jan 24, 2017
| @@ -13,6 +13,10 @@ const fs = require("fs"); | |||
| const fixtureLoc = path.join(__dirname, "fixtures"); | |||
| const tmpLoc = path.join(__dirname, "tmp"); | |||
|
|
|||
| const fileFilter = function(x) { | |||
| return x !== ".DS_Store"; | |||
There was a problem hiding this comment.
I guess this was making interference during the tests. Since .DS_Store are ignored in Git I think this shouldn't happen so often.
existentialism
force-pushed
the
babel-cli-out-files
branch
from
eb2c507
to
20ebe2c
Compare
existentialism
force-pushed
the
babel-cli-out-files
branch
from
20ebe2c
to
06c219a
Compare
|
Updated to include some tests for the new ignore/only behavior with |
hzoo
approved these changes
Mar 23, 2017
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
readDir, which enables us to include dotfiles when creatingopts.inFilesandopts.outFilesout-filesfor matching, missing and extraneous filesWhile digging a little deeper into #5083, I noticed that
babel-clitests were only comparingout-filesto generated (and not vice versa), which doesn't check for missing or extraneous files.This would make testing
--copy-filesand the potential new--copy-dot-filesflags hard :)This should also allow us to write more comprehensive tests for
babel-cli.