-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[skip ci] Add devEngines to package.json #5312
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5312 +/- ##
=======================================
Coverage 89.44% 89.44%
=======================================
Files 204 204
Lines 9950 9950
Branches 2688 2688
=======================================
Hits 8900 8900
Misses 1050 1050 Continue to review full report at Codecov.
|
package.json
Outdated
@@ -46,6 +46,10 @@ | |||
"through2": "^2.0.0", | |||
"uglify-js": "^2.4.16" | |||
}, | |||
"devEngines": { | |||
"node": "0.12 || 4.x || 5.x || 6.x || 7.x", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have drop node 0.12. I guess we can remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current version from master builds on 0.12 🤔 . All works except linting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We support 0.10 on 6.x as well (circle ci) https://github.com/babel/babel/blob/master/circle.yml which we removed in 7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though I wouldn't suggest to anyone to develop babel on node <4. I would say for developing people should use latest or LTS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For our own development? Oh yeah definetely at least 6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
devEngines is not about recommendations but just shows where stuff could technically work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe once preset-env will support engines and we drop es2015 in favor of env. 😏
React uses the Should we also use this? |
@xtuc yeah, I thought it as a separate PR. I don't know what's better, script from fbjs or make new for own needs. |
@yavorsky I think the FB script is fine (see source). This will make a new devDependency, but we could use other work they done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok for me on master
.
Since 7.0
drops 0.10 and 0.12.
devEngines
is a good way to show environment where build script is expected to work.Also, going to add for 7.0 brunch without 0.12.