-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap some generated do expressions in parens #5339
Conversation
@zjmiller, thanks for your PR! By analyzing the history of the files in this pull request, we identified @existentialism, @hzoo and @loganfsmyth to be potential reviewers. |
=) |
Ah cool. I'll take out the duplicate files from my PR and just leave the parentheses-related stuff. |
Codecov Report
@@ Coverage Diff @@
## master #5339 +/- ##
==========================================
+ Coverage 89.44% 89.48% +0.04%
==========================================
Files 204 204
Lines 9949 9951 +2
Branches 2689 2689
==========================================
+ Hits 8899 8905 +6
+ Misses 1050 1046 -4
Continue to review full report at Codecov.
|
A do expression at the beginning of a statement needs to be wrapped in parentheses. Otherwise the parser will think it is a do...while statement. I modified
babel-generator
to add these parentheses.