Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix babel-runtime helpers gererator #5539

Merged
merged 1 commit into from
Mar 24, 2017
Merged

Fix babel-runtime helpers gererator #5539

merged 1 commit into from
Mar 24, 2017

Conversation

azrael
Copy link
Contributor

@azrael azrael commented Mar 24, 2017

Q A
Patch: Bug Fix? yes
Major: Breaking Change? no
Minor: New Feature? no
Deprecations? no
Spec Compliancy? no
Tests Added/Pass? no
Fixed Tickets no
License MIT
Doc PR no
Dependency Changes no

Fixed a bug in babel-runtime helper generator where invalid helpers were created and as a result there were the Unterminated string constant errors.

@mention-bot
Copy link

@Azrael25, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Kovensky, @hzoo and @loganfsmyth to be potential reviewers.

@azrael azrael changed the title fix babel-runtime helpers gererator Fix babel-runtime helpers gererator Mar 24, 2017
@codecov
Copy link

codecov bot commented Mar 24, 2017

Codecov Report

Merging #5539 into 7.0 will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              7.0    #5539      +/-   ##
==========================================
- Coverage   85.49%   85.47%   -0.03%     
==========================================
  Files         200      200              
  Lines        9506     9506              
  Branches     2701     2701              
==========================================
- Hits         8127     8125       -2     
- Misses        883      885       +2     
  Partials      496      496
Impacted Files Coverage Δ
packages/babel-traverse/src/visitors.js 85.71% <0%> (-0.96%) ⬇️
packages/babel-traverse/src/path/context.js 85.34% <0%> (-0.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0b6db1...5b0c3a1. Read the comment docs.

@hzoo
Copy link
Member

hzoo commented Mar 24, 2017

Wow good catch

@hzoo hzoo added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Mar 24, 2017
@hzoo hzoo merged commit 0eb898d into babel:7.0 Mar 24, 2017
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants