🐶 🍲 #5543
🐶 🍲 #5543
Conversation
hzoo
added
the
PR: Internal 🏠
|
@hzoo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bcoe, @danez and @ChauTNguyen to be potential reviewers. |
Codecov Report
@@ Coverage Diff @@
## 7.0 #5543 +/- ##
=========================================
+ Coverage 85.45% 85.5% +0.05%
=========================================
Files 200 200
Lines 9506 9506
Branches 2701 2701
=========================================
+ Hits 8123 8128 +5
+ Misses 887 882 -5
Partials 496 496
Continue to review full report at Codecov.
|
Gulpfile.js
Outdated
| @@ -7,6 +7,7 @@ var watch = require("gulp-watch"); | |||
| var gutil = require("gulp-util"); | |||
| var gulp = require("gulp"); | |||
| var path = require("path"); | |||
| var babelConfig = require("./.babelrc"); | |||
There was a problem hiding this comment.
Shouldn't it pick up the config automatically?
There was a problem hiding this comment.
It was failing, not sure why so did this for now
maybe you can look at babel/gulp-babel#112
.babelrc.js
Outdated
| @@ -0,0 +1,21 @@ | |||
| module.exports = { | |||
| "comments": false, | |||
There was a problem hiding this comment.
Do we want to keep quotes on keys?
There was a problem hiding this comment.
We don't have to, I just copy pasted the config over!
scripts/babel-register.js
Outdated
| const babel = require("../package.json").babel; | ||
| const register = require("babel-register"); | ||
| const babel = require("../.babelrc"); | ||
| const register = require("babel-register").default; | ||
| const path = require("path"); | ||
|
|
||
| if (babel.plugins) { |
There was a problem hiding this comment.
Do we need this logic anymore?
There was a problem hiding this comment.
not sure why it was added before I guess not?
.babelrc.js
Outdated
| comments: false, | ||
| presets: [ | ||
| [ | ||
| require("babel-preset-env"), envOpts |
There was a problem hiding this comment.
I think the require calls here are still optional, not sure if you had a specific motivation for them.
|
Hey @hzoo! It looks like one or more of your builds have failed. I've copied the relevant info below to save you some time. |
lock
bot
added
the
outdated
No description provided.