-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use latest babel-core #5551
use latest babel-core #5551
Conversation
@hzoo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ChauTNguyen, @bcoe and @yavorsky to be potential reviewers. |
Hey @hzoo! It looks like one or more of your builds have failed. I've copied the relevant info below to save you some time. |
@@ -9,7 +9,6 @@ const watch = require("gulp-watch"); | |||
const gutil = require("gulp-util"); | |||
const gulp = require("gulp"); | |||
const path = require("path"); | |||
const babelConfig = require("./.babelrc"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scripts/babel-register.js too, right?
Hey @hzoo! It looks like one or more of your builds have failed. I've copied the relevant info below to save you some time. |
1 similar comment
Hey @hzoo! It looks like one or more of your builds have failed. I've copied the relevant info below to save you some time. |
scripts/babel-register.js
Outdated
const register = require("babel-register").default; | ||
|
||
register(babel); | ||
register(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need this call at all :)
Hey @hzoo! It looks like one or more of your builds have failed. I've copied the relevant info below to save you some time. |
Codecov Report
@@ Coverage Diff @@
## 7.0 #5551 +/- ##
=========================================
- Coverage 85.5% 85.47% -0.04%
=========================================
Files 200 200
Lines 9506 9506
Branches 2702 2702
=========================================
- Hits 8128 8125 -3
- Misses 882 885 +3
Partials 496 496
Continue to review full report at Codecov.
|
Hey @hzoo! It looks like one or more of your builds have failed. I've copied the relevant info below to save you some time. |
Ref #5550