Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use latest babel-core #5551

Merged
merged 6 commits into from
Mar 27, 2017
Merged

use latest babel-core #5551

merged 6 commits into from
Mar 27, 2017

Conversation

hzoo
Copy link
Member

@hzoo hzoo commented Mar 27, 2017

Ref #5550

@mention-bot
Copy link

@hzoo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ChauTNguyen, @bcoe and @yavorsky to be potential reviewers.

@babel-bot
Copy link
Collaborator

Hey @hzoo! It looks like one or more of your builds have failed. I've copied the relevant info below to save you some time.

@@ -9,7 +9,6 @@ const watch = require("gulp-watch");
const gutil = require("gulp-util");
const gulp = require("gulp");
const path = require("path");
const babelConfig = require("./.babelrc");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scripts/babel-register.js too, right?

@babel-bot
Copy link
Collaborator

Hey @hzoo! It looks like one or more of your builds have failed. I've copied the relevant info below to save you some time.

1 similar comment
@babel-bot
Copy link
Collaborator

Hey @hzoo! It looks like one or more of your builds have failed. I've copied the relevant info below to save you some time.

const register = require("babel-register").default;

register(babel);
register();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need this call at all :)

@babel-bot
Copy link
Collaborator

Hey @hzoo! It looks like one or more of your builds have failed. I've copied the relevant info below to save you some time.

@codecov
Copy link

codecov bot commented Mar 27, 2017

Codecov Report

Merging #5551 into 7.0 will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             7.0    #5551      +/-   ##
=========================================
- Coverage   85.5%   85.47%   -0.04%     
=========================================
  Files        200      200              
  Lines       9506     9506              
  Branches    2702     2702              
=========================================
- Hits        8128     8125       -3     
- Misses       882      885       +3     
  Partials     496      496
Impacted Files Coverage Δ
packages/babel-helper-call-delegate/src/index.js 64% <0%> (-4%) ⬇️
packages/babel-traverse/src/path/modification.js 73.78% <0%> (-0.98%) ⬇️
packages/babel-traverse/src/visitors.js 85.71% <0%> (-0.96%) ⬇️
...bel-plugin-transform-es2015-classes/src/vanilla.js 89.74% <0%> (-0.43%) ⬇️
packages/babel-traverse/src/path/context.js 86.2% <0%> (+0.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dea5093...fa23b66. Read the comment docs.

@babel-bot
Copy link
Collaborator

Hey @hzoo! It looks like one or more of your builds have failed. I've copied the relevant info below to save you some time.

@hzoo hzoo added the PR: Internal 🏠 A type of pull request used for our changelog categories label Mar 27, 2017
@hzoo hzoo merged commit 899daaf into 7.0 Mar 27, 2017
@hzoo hzoo deleted the fix branch April 5, 2017 19:15
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants