Ensure that incremental builds work with 'gulp build'. #5561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
loganfsmyth
commented
Mar 28, 2017
loganfsmyth
commented
| Q | A |
|---|---|
| Patch: Bug Fix? | N |
| Major: Breaking Change? | N |
| Minor: New Feature? | N |
| Deprecations? | |
| Spec Compliancy? | |
| Tests Added/Pass? | |
| Fixed Tickets | |
| License | MIT |
| Doc PR | |
| Dependency Changes |
|
@loganfsmyth, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hzoo and @bcoe to be potential reviewers. |
loganfsmyth
commented
Mar 28, 2017
| } else { | ||
| srcEx = new RegExp("(packages/[^/]+)/src/"); | ||
| libFragment = "$1/lib/"; | ||
| function swapSrcWithLib(srcPath) { |
There was a problem hiding this comment.
These regexes were gross, so figured this would be easier to follow.
loganfsmyth
commented
Mar 28, 2017
| gulp.task("default", ["build"]); | ||
|
|
||
| gulp.task("build", function () { | ||
| return gulp.src(scripts) | ||
| return gulp.src(scripts, { base: base }) |
There was a problem hiding this comment.
This was the core of the problem, we weren't setting a base, so all the filepaths were babel-core/src/index.js, and the regexes all expected the path to start with packages.
loganfsmyth
commented
Mar 28, 2017
| .pipe(through.obj(function (file, enc, callback) { | ||
| gutil.log("Compiling", "'" + chalk.cyan(file.path) + "'..."); | ||
| gutil.log("Compiling", "'" + chalk.cyan(file.relative) + "'..."); |
There was a problem hiding this comment.
This I just changed since it seems easier to read.
|
Nice work! |
existentialism
added
the
PR: Internal 🏠
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.