Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid creating a new line comment when a block comment is preceded by a forward slash #5562

Merged
merged 1 commit into from
Apr 9, 2017

Conversation

tgecho
Copy link
Contributor

@tgecho tgecho commented Mar 28, 2017

Q A
Patch: Bug Fix? yes
Major: Breaking Change? no
Minor: New Feature? no
Deprecations? no
Spec Compliancy? yes
Tests Added/Pass? yes
Fixed Tickets Fixes #5557
License MIT
Doc PR no
Dependency Changes no

Adds a space before block comments if the preceding character is a forward slash. This prevents an expression such as 1 / /* comment */ 1 from getting mangled into 1//* comment */1 in compact mode.

@mention-bot
Copy link

@tgecho, thanks for your PR! By analyzing the history of the files in this pull request, we identified @loganfsmyth, @hzoo and @existentialism to be potential reviewers.

@existentialism existentialism added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Mar 28, 2017
@loganfsmyth loganfsmyth merged commit 769eddc into babel:7.0 Apr 9, 2017
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants