Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change babel-register default ignore to cwd content. #5583

Merged
merged 1 commit into from
Apr 4, 2017

Conversation

loganfsmyth
Copy link
Member

Q A
Patch: Bug Fix? Y, from #5487
Major: Breaking Change? N
Minor: New Feature? N
Deprecations?
Spec Compliancy?
Tests Added/Pass?
Fixed Tickets
License MIT
Doc PR
Dependency Changes

I realized that I regressed this behavior from https://github.com/babel/babel/pull/5487/files#diff-75a0292ed78043766c2d5564edd84ad2L92

The behavior of babel-register in 6.x is equivalent to:

function shouldIgnore(filename){
  return (isInAnyNodeModules(filename) && !isInCwd(filename)) ||
    isInCwdNodeModules(filename);
}

assuming I'm covering all the edge cases here finally. The relative directory logic that was there before was pretty confusing and I misunderstood it the first time.

Currently I broke it by making it

function shouldIgnore(filename){
  return isInCwdNodeModules(filename);
}

which will try to compile node_modules that are not nested in the working directory, like things that are symlinked.

@mention-bot
Copy link

@loganfsmyth, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hzoo, @existentialism and @forivall to be potential reviewers.

@loganfsmyth loganfsmyth merged commit 9155c61 into babel:7.0 Apr 4, 2017
@loganfsmyth loganfsmyth deleted the register-ignore-fix branch April 4, 2017 21:47
@existentialism existentialism added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Apr 5, 2017
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants